Jan Engelhardt <jengelh@xxxxxxx> wrote: > On Sunday 2012-09-16 23:29, Florian Westphal wrote: > > > >- dest port and dest address were only written, never read > >- struct inaddr isn't needed either, just look at iph->saddr > > > I have applied 01..04, with some redactional changes (diff > 975f017..093f3b0). Alright, the changes are ok; I'll update the remaining patches to use stdint-types. > >-static inline int hashfunc(struct in_addr addr) > >+static unsigned int hashfunc(__be32 addr) > > You are changing the type of hash here. While I concur with using an > unsigned quantity for a hash value, this is not done consistenly - there > are some (signed) "int hash"s left in the code. Can I get a patch that > rectifies this consistently across the entire .c file as well? Sure; I'll rebase to remaining patches on top of your tree. > BTW, does the _10 in your branch name have any significance? :) Not really; I usually start out with foo_01 and then increment the number when rebasing/structuring the changeset. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
