Re: [PATCH] netfilter: fix out-of-bounds access in nat addr selection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 05, 2012 at 10:10:28PM +0200, Florian Westphal wrote:
> include/linux/jhash.h:138:16: warning: array subscript is above array bounds
> [jhash2() expects the number of u32 in the key]

Applied to -next, thanks Florian.

> Signed-off-by: Florian Westphal <fw@xxxxxxxxx>
> ---
> Only affects -next.
> note that I also get same warning for hash_by_src(); but
> hash = jhash2((u32 *)&tuple->src, sizeof(tuple->src) / sizeof(u32),
> 	      tuple->dst.protonum ^ zone ^ nf_conntrack_hash_rnd);
> looks correct to me.

It also seems correct to me, that tuple->src is 5*4 bytes long.

I'm not hitting any warning with gcc-4.7 though.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux