On Sun, Aug 19, 2012 at 07:11:32PM -0600, Jean Sacren wrote: > Usually it's a good practice to use goto statement for error recovery > when initializing the module. This approach could be an overkill if: > > 1) there is only one fail case; > 2) success and failure use the same return statement. > > For a cleaner approach, remove the unnecessary goto statement and > directly implement error recovery. Applied, thanks Jean. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html