Hi, Michal! On Fri, 2012-08-17 at 19:05 +0200, Michal Kubeček wrote: > On Friday 17 of August 2012 16:02EN, Cong Wang wrote: > > Two years ago, Shan Wei tried to fix this: > > http://patchwork.ozlabs.org/patch/43905/ > > > ... > > > > As Herbert suggested, we could actually use the standard IPv6 > > reassembly code which follows RFC2460. > > I tested the patch and I ran into a problem in this place in > ip6_expire_frag_queue(): > > > net = container_of(fq->q.net, struct net, ipv6.frags); > > For frag queues coming from IPv6 conntrack, fq->q.net points to > nf_init_frags which is not embedded into struct net so that the > following device lookup leads to reading from an invalid address. > The same problem has been discussed on the page linked above. > > I didn't test with current net-next source but as far as I can tell, > this hasn't changed. Did I miss something? > No, you don't miss anything. I missed that piece of code, you are right that nf_init_frags is not actually embedded, so that container_of() doesn't work. I think we probably can save the struct net pointer in struct netns_frags during inet_frags_init_net(), so that container_of() can be eliminated. Thanks for testing! I tried to test it too, but seems I can't trigger a defragment. Any hints? Thanks! -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
