On Mon, 25 Jun 2012, Pablo Neira Ayuso wrote: > On Sun, Jun 17, 2012 at 09:56:46PM +0200, Florian Westphal wrote: > > ifname_compare() assumes that skb->dev is zero-padded, > > e.g 'eth1\0\0\0\0\0...'. This isn't always the case. e1000 driver does > > > > strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1); > > > > in e1000_probe(), so once device is registered dev->name memory contains > > 'eth1\0:0:3\0\0\0' (or something like that), which makes eth1 compare > > fail. > > > > Use plain strcmp() instead. > > Applied, thanks Florian. Thanks, Pablo! I had commited the patch in my ipset git tree, just haven't time yet to send/ack to you. Best regards, Jozsef - E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
