Hello Pablo Neira Ayuso,
This is a semi-automatic email about new static checker warnings.
The patch 1afc56794e03: "netfilter: nf_ct_helper: implement variable
length helper private data" from Jun 7, 2012, leads to the following
Smatch complaint:
net/netfilter/nf_conntrack_netlink.c:1231 ctnetlink_change_helper()
error: we previously assumed 'help->helper' could be null (see line 1228)
net/netfilter/nf_conntrack_netlink.c
1227 }
1228 if (help->helper)
^^^^^^^^^^^^
If help->helper is non-NULL we return here.
1229 return -EBUSY;
1230 /* need to zero data of old helper */
1231 memset(help->data, 0, help->helper->data_len);
^^^^^^^^^^^^^^^^^^^^^^
This is always lead to a NULL dereference here.
1232 } else {
1233 /* we cannot set a helper for an existing conntrack */
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
