Hi pablo 于 2012年06月06日 07:56, Pablo Neira Ayuso 写道: > On Tue, May 29, 2012 at 03:04:09PM +0800, Gao feng wrote: >> From: Gao feng <gaofeng@xxxxxxxxxxxxxx> >> >> struct nf_proto_net stroes proto's ctl_table_header and ctl_table, >> nf_ct_l4proto_(un)register_sysctl use it to register sysctl. >> because AF_INET6's protocols need not do compat, so register or >> unregister sysctl when l4proto.l3proto != AF_INET6. >> >> - the net_id field is used to store the pernet_operations id >> that belones to l4proto. >> >> - init_net will be used to initial the proto's pernet data >> >> - nf_ct_(un)register_sysctl are changed to support net namespace, >> use (un)register_net_sysctl_table replaces (un)register_sysctl_paths. >> and in nf_ct_unregister_sysctl,kfree table only when users is 0. >> >> - Add the struct net as param of nf_conntrack_l4proto_(un)register. >> register or unregister the l4proto only when the net is init_net. >> >> - nf_conntrack_l4proto_register call init_net to initial the pernet >> data of l4proto. >> >> - nf_ct_l4proto_net is used to get the pernet data of l4proto. >> >> - use init_net as a param of nf_conntrack_l4proto_(un)register. > > I have applied this patchset, but I had to rewrite the patch > descriptions. > > I don't blame your English neither your writing abilities (I'm not > native speaker and not that good at writing either) but I think you > can make it better next time. I apologize for my pool English and writing abilities. Maybe I should take an english course... > > Basically, you don't need to comment every single change that the > patch does. That's easy to see by looking at the patchset. > > Instead, just provide brief explanation on your intentions with the > patch, clarify things that may look not obvious to the reviewer and > what we'll get with this. Got it, thanks for teaching me this. ;) > -- > To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
