On Thu, May 17, 2012 at 10:39:28AM +0200, Eric Dumazet wrote: > On Thu, 2012-05-17 at 09:16 +0100, David Laight wrote: > > > From: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> > > > > > > Use: > > > > > > ((u64)(HASH_VAL * HASH_SIZE)) >> 32 > > > > > > as suggested by David S. Miller. > > > > That (u64) cast is very unlikely to have any effect. > > If you want a 64 bit result from the product of two > > 32 bit values, you have to cast one of the 32 bit values > > prior to the multiply - as in the patch below. > > Hey, Changelog is a bit wrong (for several reasons) but code is correct. > > return (((u64)hash * info->hmodulus) >> 32) + info->hoffset; Sorry, for the mistake in the changelog. I copied & pasted it from the mailing list discussion. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
