On Mon, May 07, 2012 at 09:34:18PM -0400, David Miller wrote:
> From: pablo@xxxxxxxxxxxxx
> Date: Tue, 8 May 2012 02:21:56 +0200
>
> > + if (!net->ct.helper_sysctl_header) {
> > + printk(KERN_ERR "nf_conntrack_helper: can't register to sysctl.\n");
> > + goto out_register;
> > + }
>
> Please use pr_err().
>
> > + printk(KERN_INFO "nf_conntrack: automatic helper "
> > + "assignment is deprecated. Please, read "
> > + "http://www.netfilter.org/news.html#2012-04-03\n";);
> > + net->ct.auto_assign_helper_warned = true;
>
> Please use pr_info().
>
> Pointers to web sites to explain a problem is absolutely not
> appropriate in kernel log messages, nor commit messages.
>
> Either add a document to the kernel tree, or explain things
> fully both in the kernel log message and the commit message.
I'll fix those. Thanks for spotting this issue.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
