On Fri, Apr 13, 2012 at 01:11:50PM +0900, Simon Horman wrote: > On Fri, Apr 13, 2012 at 02:54:13AM +0200, Sasha Levin wrote: > > On Thu, Apr 12, 2012 at 1:46 AM, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > >> If you return here, I think you'll leave things in inconsistent state, > > >> ie. the tcp protocol is registered. You have to unregister it before > > >> leaving. > > > > I thought that the cleanup callback is getting called for failed init > > calls, if that's not the case then we can probably call it ourselves > > if any of these failed. > > Good point. In any case, I think that I have found a new problem. [sni@] I have confirmed that the cleanup code is called on error, so I think that your existing patch is fine. Acked-by: Simon Horman <horms@xxxxxxxxxxxx> Pablo, please consider taking this change. The other problem I raised, though related, can be handled separately as it won't occur if the ftp helper isn't initialised. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
