On Mon, Apr 2, 2012 at 11:29 AM, David Miller <davem@xxxxxxxxxxxxx> wrote: > > Tag Eric, you're it. > > You ACK'd this patch, so you get to show how this is actually able > to cause some kind of problem. > > I assert that this is adding a useless test, that doesn't fix any kind > of possible crash or misbehavior. If length == 1 at the default:, the > code will absolutely do the right thing. > > Prove me wrong. Thinking about a malformed tcp segment, which has no data but silly options, and whose last byte is neither TCPOPT_EOL or TCPOPT_NOP, we will try to dereference one byte over the boundary when parsing the options. I know we have skb_shared_info at the end and it won't cause any crash, but should we rely on this fact? -- Regards, Changli Gao(xiaosuo@xxxxxxxxx) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
