>>> On 19.03.12 at 09:47, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: >> >> > Using the (bogus and unused elsewhere) >> >> > __exit_refok to implement this is inefficient - any non-modular code >> >> > really can reside in __init (as non-modular __exit code is never used). > >> > 2) fix up the bogus commit message >> >> Bogus in what way? > > I fail to see that __exit_refok is bogus. Either an exit function references only permitted code (in which case it is legitimately using __exit), or it references non-__exit code, in which case it shouldn't have an override at all. Permitting an exit function to reference e.g. __init code is suspicious (at best) in all cases I can think of (in contrast to allowing a non-init function to reference __init code on a code path that can be proven to be taken only during system startup). Jan > The name is not optimal - which is why is is deprecated. > > Sam -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
