On Tue, Mar 06, 2012 at 03:16:18PM -0500, David Miller wrote:
> From: pablo@xxxxxxxxxxxxx
> Date: Tue, 6 Mar 2012 12:22:55 +0100
>
> > From: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
> >
> > If reliable event delivery is enabled and ctnetlink fails to deliver
> > the destroy event in early_drop, the conntrack subsystem cannot
> > drop any the candidate flow that was planned to be evicted.
> >
> > Reported-by: Kerin Millar <kerframil@xxxxxxxxx>
> > Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
>
> Applied.
>
> > + /* Check if we indeed killed this entry. Reliable event
> > + delivery may have inserted it into the dying list. */
> > + if (test_bit(IPS_DYING_BIT, &ct->status)) {
>
> Please don't allow misformatted comments like this into your
> tree next time, this should be:
>
> /* Check if we indeed killed this entry. Reliable event
> * delivery may have inserted it into the dying list.
> */
Thanks for spotting this.
Will in the future (probably some patches that I took for net-next
may not follow this format either, but for upcoming patches I will).
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
