Op 5/03/2012 12:13, Florian Westphal schreef:
When net.bridge.bridge-nf-filter-vlan-tagged is 0 (default), vlan packets arriving should not be sent to ip(6)tables by bridge netfilter.
+#define IS_ARP(skb) \ + (!vlan_tx_tag_present(skb)&& skb->protocol == htons(ETH_P_ARP)) +
I could nitpick on the lack of a space before the && (it's also in other places in your patch). Is that intentional? I've never seen this coding style before and you don't seem to do it for ||. Apart from that it's a very clean patch. I leave it up to you and Pablo to decide if this needs to be changed before applying the patch.
Thanks, Bart -- Bart De Schuymer www.artinalgorithms.be -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
