Re: Question about nfnl_handle_packet/nfnl_process error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> > When an error occurs, for example because a verdict for a bogus packet id was
> > sent, nfq_handle_packet/nfnl_handle_packet returns -1 with errno == 0.
> > 
> > Using nfnl_process() instead of nfq_handle_packet() sets errno to the expected
> > ENOENT.
> > 
> > Does anyone know if nfq_handle_packet() "errno 0" behaviour is intentional?
> 
> The initial libnfnetlink API did not set errno, nfnl_handle_packet is
> part of that old API.
> 
> nfnl_process was added later to try to resolve some limitations by
> 2006 IIRC.

Ah.  That explains it, thanks.

> > Should I just ignore nfq_handle_packet() return value?
> > What about deprecating nfnl_handle_packet() and using nfnl_process()
> > instead?
> 
> I have ported libnetfilter_queue to libmnl, I need some spare time to
> push the new API to the repository. I'll be happy if you spend some
> time looking at it to find some possible issues, the idea is that the
> new API resolves the existing API limitations.

Nice work. I'd be happy to test and review it.

Thanks, Florian
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux