On Wed, Feb 1, 2012 at 2:24 AM, Jan Engelhardt <jengelh@xxxxxxxxxx> wrote: > On Monday 2012-01-30 10:01, richard -rw- weinberger wrote: > >>On Sun, Jan 22, 2012 at 10:56 PM, Richard Weinberger <richard@xxxxxx> wrote: >>> ipt_LOG and ip6_LOG have a lot of common code, merge them >>> to reduce duplicate code. >>> >>> Signed-off-by: Richard Weinberger <richard@xxxxxx> >> >>No comments? > > Adding Pablo to Cc. > > > Do you have the patchset as a retrievable git tree, btw? Only for kernel stuff: git://git.kernel.org/pub/scm/linux/kernel/git/rw/misc.git xt_LOG If you want it for the user space part too, I can setup something... > >>[PATCH 6/6] iptables: xt_LOG: Add ring buffer support >> >>in libxt_LOG.c: >>+.size = XT_ALIGN(sizeof(struct xt_log_info_v1) + sizeof(void *)), > > Why the extra void*? The kernel space part of xt_log_info_v1 differs from the user space struct, it contains an extra pointer to the ring buffer context. Iptables must not see this extra pointer because the kernel writes to it. -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
