In case you notice: On Sat, Dec 24, 2011 at 02:25:46AM +0100, pablo@xxxxxxxxxxxxx wrote: > +struct nf_acct *nfnl_acct_find_get(const char *acct_name) > +{ > + struct nf_acct *cur, *acct = NULL; > + > + rcu_read_lock(); > + list_for_each_entry_rcu(cur, &nfnl_acct_list, head) { > + if (strncmp(cur->name, acct_name, NFACCT_NAME_MAX)!= 0) > + continue; > + > + if (!try_module_get(THIS_MODULE)) > + goto err; > + > + if (!atomic_inc_not_zero(&cur->refcnt)) { > + module_put(THIS_MODULE); > + goto err; > + } > + > + acct = cur; > + break; > + } > + rcu_read_unlock(); > +err: I've fixed this here. Now the err label goes before the rcu_read_unlock ;-) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html