RE: [v4 PATCH 2/2] NETFILTER userspace part for target HMARK

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>On Friday 2011-11-25 10:36, Hans Schillstrom wrote:
>
>>+Parameters:
>>+For all masks default is all "1:s", to disable a field use mask 0
>>+For IPv6 it's just the last 32 bits that is included in the hash
>
>Why limit IPv6 to 32?

Performance, and the gain of adding another 192 bits to jhash ain't much.
However there is some cases when it hurts, i.e. when you can't mask of an subnet
I'm not sure it it's a problem or not... 

>>diff --git a/include/linux/netfilter/xt_hmark.h b/include/linux/netfilter/xt_hmark.h
[snip]
>
>This file does not match the kernel-side xt_hmark.h.
>Definitions only used within the userspace side should go into libxt_hmark.c
>anyhow.

Oop,s just forgot to copy the file :-)

>>+union ports {
>>+      struct {
>>+              __u16   src;
>>+              __u16   dst;
>>+      } p16;
>>+      __u32   v32;
>>+};
>
>Bad name "ports", big clash potential.

Yes, I'll change that..

Thanks
Hans--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux