--On 9 November 2011 15:34:23 +0100 Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
wrote:
I recall myself writing that net->nfnl NULL check is racy or
something like that (but I can't find this email in archives).
I've read the code once again, and I'm quite sure,
NULL ->nfnl check is correct if RCU precautions are made.
Regarding ->report check, I think it's bogus.
If there are no listeners, there are NO listeners
and whether to report back to userspace doesn't matter.
I'm sure I'm missing something obvious here.
Please, review.
Alexey. This is a workaround. We have to make ctnl_notifier
container-aware which is the real problem.
It is indeed a workaround. However, until we have a real solution,
we need a workaround, or we can trivially generate fatal oopses.
I am all for fixing it properly, but please can we leave the workaround
in place until we have the proper answer, as without this we see
machines die frequently.
--
Alex Bligh
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
