On Mon, Sep 12, 2011 at 12:48:36PM +0200, Jan Engelhardt wrote:
>
> On Monday 2011-09-12 11:32, Pablo Neira Ayuso wrote:
> >>
> >> -static int show_binary = 0, show_counters = 0;
> >> +static int show_counters = 0;
> >>
> >> static const struct option options[] = {
> >> - {.name = "binary", .has_arg = false, .val = 'b'},
> >
> >Please, better something less agressive like displaying a message
> >telling "-b option was never implemented, ignoring it".
> >
> >So if anyone, for some strange reason, is using it, their scripts will
> >not break.
> >
> >I know this may sound a bit nitpicking but I think it's good to make
> >sure that we don't break anything.
>
> I think we are not talking about the same thing. If you run
> `iptables-save -b`, the program will exit with status 1 without
> printing anything related to rules. (Outputs "binary NYI" which, if
> you happen to be able to resolve the acronym, expands to "not yet
> implemented")
>
> How would that be any better than getting "invalid option: -B"?
Well, we'll hit that anyway once you remove -b option.
> It is "NYI". Given the issues with binary representations that have
> come up within the last 10 years so far, I doubt that we have a
> reason to offer wanting to dump the packed ruleset right now.
Fair enough, go ahead.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
