On Tue, 21 Jun 2011, Jesper Juhl wrote: > It was suggested by "make versioncheck" that the follwing includes of > linux/version.h are redundant: > > /home/jj/src/linux-2.6/net/caif/caif_dev.c: 14 linux/version.h not needed. > /home/jj/src/linux-2.6/net/caif/chnl_net.c: 10 linux/version.h not needed. > /home/jj/src/linux-2.6/net/ipv4/gre.c: 19 linux/version.h not needed. > /home/jj/src/linux-2.6/net/netfilter/ipset/ip_set_core.c: 20 linux/version.h not needed. > /home/jj/src/linux-2.6/net/netfilter/xt_set.c: 16 linux/version.h not needed. > > and it seems that it is right. > > Beyond manually inspecting the source files I also did a few build > tests with various configs to confirm that including the header in > those files is indeed not needed. > > Here's a patch to remove the pointless includes. > > Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx> > --- > net/caif/caif_dev.c | 1 - > net/caif/chnl_net.c | 1 - > net/ipv4/gre.c | 1 - > net/netfilter/ipset/ip_set_core.c | 1 - > net/netfilter/xt_set.c | 1 - > 5 files changed, 0 insertions(+), 5 deletions(-) For ipset/xt_set.c: Acked-by: Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx> Best regards, Jozsef - E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlec@xxxxxxxxxxxx PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : KFKI Research Institute for Particle and Nuclear Physics H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
