Re: [PATCH 1/4] netfilter: xtables: move ipt_ecn to xt_ecn

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 2011-06-16 17:34, Patrick McHardy wrote:

>On 16.06.2011 17:31, Jan Engelhardt wrote:
>> 
>> On Thursday 2011-06-16 17:21, Patrick McHardy wrote:
>>> On 09.06.2011 22:23, Jan Engelhardt wrote:
>>>> --- a/net/ipv4/netfilter/Kconfig
>>>> +++ b/net/ipv4/netfilter/Kconfig
>>>> @@ -76,11 +76,11 @@ config IP_NF_MATCH_AH
>>>>  config IP_NF_MATCH_ECN
>>>>  	tristate '"ecn" match support'
>>>>  	depends on NETFILTER_ADVANCED
>>>> -	help
>>>> -	  This option adds a `ECN' match, which allows you to match against
>>>> -	  the IPv4 and TCP header ECN fields.
>>>> -
>>>> -	  To compile it as a module, choose M here.  If unsure, say N.
>>>> +	select NETFILTER_XT_MATCH_ECN
>>>> +	---help---
>>>> +	This is a backwards-compat option for the user's convenience
>>>> +	(e.g. when running oldconfig). It selects
>>>> +	CONFIG_NETFILTER_XT_MATCH_ECN.
>>>>  
>>>
>>> Did this work? I've tried myself, but it would still show the new
>>> option.
>> 
>> What do you mean? Of course it is supposed to show NETFILTER_XT_MATCH_ECN.
>
>Well, ideally not, but fine as long as its still automatically
>selected.
>
>I'll pull your patches once the first two fixes are upstream.

We are doing the same thing with the old options for nfmark/ctmark
(cf. Documentation/feature-removal-schedule.txt) so I guess that was ok.
The old options are supposed to be gone in a few releases anyway.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux