static analysis (analysis based only on compiling of sources, not based on running of binary)
of the code revealed the following problem:
libnfnetlink.c:481: Taking the size of pointer parameter "nlh" is suspicious.
libnfnetlink.c:486: Taking the size of pointer parameter "nlh" is suspicious.
---
src/libnfnetlink.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/libnfnetlink.c b/src/libnfnetlink.c
index 6e7afc6..2f962fc 100644
--- a/src/libnfnetlink.c
+++ b/src/libnfnetlink.c
@@ -477,12 +477,12 @@ nfnl_parse_hdr(const struct nfnl_handle *nfnlh,
if (nlh->nlmsg_len == NLMSG_LENGTH(sizeof(struct nfgenmsg))) {
if (genmsg)
- *genmsg = (void *)nlh + sizeof(nlh);
+ *genmsg = (void *)nlh + sizeof(*nlh);
return NULL;
}
if (genmsg)
- *genmsg = (void *)nlh + sizeof(nlh);
+ *genmsg = (void *)nlh + sizeof(*nlh);
return (void *)nlh + NLMSG_LENGTH(sizeof(struct nfgenmsg));
}
--
1.7.5.2
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
