Re: [RFC] SLOB breaks netfilter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Thus spake David Miller (davem@xxxxxxxxxxxxx):
> From: Sebastian Andrzej Siewior <sebastian@xxxxxxxxxxxxx>
> Date: Tue, 7 Jun 2011 23:06:51 +0200
> 
> > and SLOB defines:
> > 
> > |#ifdef ARCH_DMA_MINALIGN
> > |#define ARCH_KMALLOC_MINALIGN ARCH_DMA_MINALIGN
> > |#else
> > |#define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long)
> > |#endif
> 
> SLOB should really use "unsigned long long" I think.
> 
> An allocator needs to provide memory with the maximum
> alignment that might be required for types on a given
> architecture.

The larger alignment is due to u64 in the counter struct. However, it still
needs two loads/stores for it on my 32bit powerpc here.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux