Hello, On Wed, 8 Jun 2011, Patrick McHardy wrote: > >> to the IPS_SEQ_ADJUST_BIT case to at least avoid it in some cases. > >> Would that work or am I missing something? > > > > Logically, the new check can be after > > test_bit(IPS_SEQ_ADJUST_BIT, &ct->status). But I suspect > > some modules adjust seqs in the helper->help call, > > for example, sip_help_tcp if I'm correctly reading the > > code. > > Yes, you're right. But it's the only one since it's the only helper > doing possibly many modifications on a single TCP packet, which can't > be handled by the generic code properly. So if you're worried about > performance costs, I'd have no problems adding this check to the SIP > helper. OK, I'm posting new version just for seq adjustment. I'm not fixing sip_help_tcp because I'm not sure what is the right fix, we must be sure that calling sip_help_tcp twice is not a problem. Regards -- Julian Anastasov <ja@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
