Re: [PATCH] netfilter: nf_nat: fix crash in nf_nat_csum

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07.06.2011 22:02, Julian Anastasov wrote:
> 
> 	Hello,
> 
> On Tue, 7 Jun 2011, Patrick McHardy wrote:
> 
>> On 29.05.2011 22:42, Julian Anastasov wrote:
>>>
>>> 	Fix crash in nf_nat_csum when mangling packets
>>> in OUTPUT hook where skb->dev is not defined, it is set
>>> later before POSTROUTING. Problem happens for CHECKSUM_NONE.
>>> We can check device from rt but using CHECKSUM_PARTIAL
>>> should be safe (skb_checksum_help).
>>
>> We don't call helpers in LOCAL_OUT, how can this happen?
> 
> 	I think, this happened with IPVS only in OUTPUT hook: 
> tcp_snat_handler -> ip_vs_ftp_out -> nf_nat_mangle_tcp_packet -> 
> nf_nat_csum. This is again PASV FTP via loopback.

I see, thanks. I'll add a comment and will apply this tommorrow.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux