Hello, On Fri, 29 Apr 2011, Hans Schillstrom wrote: > This patch series handles exit from a network name space. > > REVISION > > This is version 3 Great! Only one missing lock: Patch 3: Missing write_[un]lock_bh(&__ip_vs_svc_lock) in ip_vs_flush, now we use ip_vs_unlink_service_nolock. As you are going to create new version you can look also at these: Patch 5: Can you rename 'goto exit;' to 'goto cleanup;' or 'goto out;' Patch 6: Add at least one comma after 'enabled' here: netns(%d) enabled first service added > OVERVIEW > Basically there was three faults in the netns implementation. > - Kernel threads hold devices and preventing an exit. > - dst cache holds references to devices. > - Services was not always released. > > Patch 1 & 3 contains the functionality > 4 renames funcctions > 5 removes empty functions > 6 Debuging. > > IMPLEMENTATION > - Avoid to increment the usage counter for kernel threads. > this is done in the first patch. > - Patch 3 tries to restore the cleanup order. > Add NETDEV_UNREGISTER notification for dst_reset > > Revision 3 > Residies in patch 3 > Throttle renamed to enable. > Comments from Julian implemented > Check enable in ip_vs_in, ip_vs_out and ip_vs_forward_icmp* > Remove in ip_vs_in_icmp*. > ip_vs_svc_reset() moved into ip_vs_dst_event(). > ip_vs_service_cleanup() uses ip_vs_flush and mutex lock. > ip_vs_unlink_service_nolock() added. Regards -- Julian Anastasov <ja@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
