Am 16.03.2011 20:00, schrieb Eric Dumazet: > We currently use a percpu spinlock to 'protect' rule bytes/packets > counters, after various attempts to use RCU instead. > > Lately we added a seqlock so that get_counters() can run without > blocking BH or 'writers'. But we really use the seqcount in it. > > Spinlock itself is only locked by the current cpu, so we can remove it > completely. > > This cleanups api, using correct 'writer' vs 'reader' semantic. > > At replace time, the get_counters() call makes sure all cpus are done > using the old table. > > We could probably avoid blocking BH (we currently block them in xmit > path), but thats a different topic ;) > > Signed-off-by: Eric Dumazet <eric.dumazet@xxxxxxxxx> > --- > This is a POC patch (based on net-next-2.6), only handling ip_tables. > ip6/arp/... need similar changes. Thanks Eric, this looks good to me. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
