Le lundi 14 mars 2011 Ã 12:45 +0900, Simon Horman a Ãcrit : > From: Julian Anastasov <ja@xxxxxx> > > The global tot_stats contains cpustats field just like the > stats for dest and svc, so better use it to simplify the usage > in estimation_timer. As tot_stats is registered as estimator > we can remove the special ip_vs_read_cpu_stats call for > tot_stats. Fix ip_vs_read_cpu_stats to be called under > stats lock because it is still used as synchronization between > estimation timer and user context (the stats readers). > > Also, make sure ip_vs_stats_percpu_show reads properly > the u64 stats from user context. > > Signed-off-by: Julian Anastasov <ja@xxxxxx> > Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx> Reviewed-by: Eric Dumazet <eric.dumazet@xxxxxxxxx> One comment : per cpu stats are really good to avoid cache misses, but I see tot_stats is included in struct netns_ipvs right after "conn_count", possibly sharing a hot cache line ? Thanks -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
