On Fri, Feb 18, 2011 at 9:46 PM, Valentijn Sessink <valentijn@xxxxxxxxxx> wrote: > Hello Netfilter devs, > > As per request from Patrick McHardy: >> https://bugzilla.kernel.org/show_bug.cgi?id=29332 >> --- Comment #3 from Patrick McHardy <kaber@xxxxxxxxx> >> Please submit your patch to netfilter-devel@xxxxxxxxxxxxxxx so others >> can have a look as well. > > ... please find attached my proposed patch - free cleanup included. > > As noted in Bugzilla, I'm by no means a programmer, so please take my > patch with a grain of salt. Also, I do realise that fixing bugs and > cleaning up should probably not be mixed, so you might want to just use > the simple (but IMHO stupid) fix: > > (info->check_set & XT_RECENT_UPDATE && (ret ^ info->invert))) IMHO, we should keep bugfix patches as clean as possible, so I prefer the above fix. Thanks. > > I hope the problem is trivial enough to not present a test case, but if > you want one, I'll make one. > > Please feel free to throw my patch away and build something more > sensible ;-) > -- Regards, Changli Gao(xiaosuo@xxxxxxxxx) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
