On Wed, 2 Feb 2011, Patrick McHardy wrote: > Add missing break statements. Thanks! It's a clear bugfix, I applied your patch. > I assume the second switch statement which handles only TCP and UDP > is intended to indicate whether a real port number instead of ICMP > port and code were parsed? Otherwise we should add IPPROTO_ICMP and > IPPROTO_ICMPV6 there too. Yes, excatly. The function is called from the bitmap:port type which can handle TCP/UDP ports only. Best regards, Jozsef - E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlec@xxxxxxxxxxxx PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : KFKI Research Institute for Particle and Nuclear Physics H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
