Re: [0/5] xtables: phase out case sensitivity

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 19.01.2011 20:44, schrieb Jan Engelhardt:
> 
> On Wednesday 2011-01-19 17:20, Patrick McHardy wrote:
>>>
>>> As a resident contributor, I stand behind the changes. In the unlikely 
>>> even that it breaks, I see it as duty to fix it. The churn is on me 
>>> already practically.
>>
>> It's quite likely that something breaks. Module aliases only work for
>> loading modules, not for unloading them. So there's a big chance that
>> some scripts will break.
> 
> Scripts can not rely on that being successful: Xtables modules may
> pull in other modules, including using things like nf_ct_get_l3proto
> which do not leave a trace in `lsmod` output. So rmmodding of xt
> modules can fail _even_ in the present situation. Not to mention that
> scripts currently have to battle the mulitple prefixes that are in
> use (which the patchset addresses in part).

Pulling in other modules though things like nf_ct_get_l3proto()
is not a problem, you just have to flush the tables before trying
to rmmod. This works well and I've seen plenty of scripts doing
exactly that.

> Since modinfo not following aliases has bothered myself for some time 
> now, I should probably just add that to m-i-t modinfo as an option and, 
> while at it, rmmod.

Sure, that sounds fine to me, though it should probably follow
aliases by default instead of as an option if you want to
preserve compatiblity when renaming things.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux