On Tue, Jan 18, 2011 at 06:14:01PM +0100, Patrick McHardy wrote: > On 18.01.2011 17:37, Jiri Olsa wrote: > > Adding support for SNMP broadcast connection tracking. The SNMP > > broadcast requests are now paired with the SNMP responses. > > Thus allowing using SNMP broadcasts with firewall enabled. > > > > Please refer to the following conversation: > > http://marc.info/?l=netfilter-devel&m=125992205006600&w=2 > > > > Patrick McHardy wrote: > >> The best solution would be to add generic broadcast tracking, the > >> use of expectations for this is a bit of abuse. > >> The second best choice I guess would be to move the help() function > >> to a shared module and generalize it so it can be used for both. > > > > This patch implements the "second best choice". > > > > Since the netbios-ns conntrack module uses the same helper > > functionality as the snmp, only one helper function is added > > for both snmp and netbios-ns modules into the new object - > > nf_conntrack_broadcast. > > > > v2 changes: > > - exporting nf_conntrack_broadcast_help via EXPORT_SYMBOL_GPL > > - nf_conntrack_broadcast object now built based on new config symbol > > NF_CONNTRACK_BROADCAST > > - changed nf_conntrack_broadcast.c copyright message > > I've applied the patch after fixeing up a few minor issues (does not > build with NF_CONNTRACK=m) by adding a MODULE_LICENSE and changing the > Kconfig bool to a tristate. > > The final patch is attached to this email. cool :) thanks a lot jirka -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
