Re: [PATCH 4/6] netfilter: reduce NF_VERDICT_MASK to 0xff

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14/01/11 15:05, Patrick McHardy wrote:
> On 12.01.2011 21:52, Florian Westphal wrote:
>> Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
>>>>  /* only for userspace compatibility */
>>>>  #ifndef __KERNEL__
>>>> @@ -41,6 +44,9 @@
>>>>     <= 0x2000 is used for protocol-flags. */
>>>>  #define NFC_UNKNOWN 0x4000
>>>>  #define NFC_ALTERED 0x8000
>>>> +
>>>> +/* NF_VERDICT_BITS should be 8 now, but userspace might break if this changes */
>>>> +#define NF_VERDICT_BITS 16
>>>>  #endif
>>>
>>> i don't find any use of this in user-space.
>>
>> Alright, I will simply remove it, then :-)
> 
> I think we should still keep it around in the compat section,
> just because we don't know of any userspace code using this
> doesn't mean it doesn't exist.

Yes, that's true, but I don't fine any sane use of that macro in userspace.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux