On 12/01/11 21:57, Jan Engelhardt wrote: > On Wednesday 2011-01-12 20:48, Pablo Neira Ayuso wrote: > >> On 12/01/11 20:15, Valdis.Kletnieks@xxxxxx wrote: >>> scripts/kconfig/conf --silentoldconfig Kconfig >>> warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED) >>> warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED) >> >> Does this fix your problem? >> > > diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig > index 1534f2b..ae56764 100644 > --- a/net/netfilter/Kconfig > +++ b/net/netfilter/Kconfig > @@ -886,7 +886,8 @@ config NETFILTER_XT_MATCH_RATEEST > config NETFILTER_XT_MATCH_REALM > tristate '"realm" match support' > depends on NETFILTER_ADVANCED > - select NET_CLS_ROUTE > + depends on NET_SCHED > + depends on NET_CLS_ROUTE > help > This option adds a `realm' match, which allows you to use the realm > key from the routing subsystem inside iptables. > > > This patch is not right. The select should just be removed, because > xt_realm is useful even without SCHED and CLS_ROUTE. I wonder why NET_CLS_ROUTE has been there as dependency. Then this patch should be fine.
netfilter: xt_realm: fix unmet direct dependencies From: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> scripts/kconfig/conf --silentoldconfig Kconfig warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED) warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED) Jan Engelhardt spotted that NET_CLS_ROUTE is a superfluous dependency, for that reason, this patch remove it. Reported by: Valdis Kletnieks <Valdis.Kletnieks@xxxxxx> Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> --- net/netfilter/Kconfig | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig index 1534f2b..8960260 100644 --- a/net/netfilter/Kconfig +++ b/net/netfilter/Kconfig @@ -886,7 +886,6 @@ config NETFILTER_XT_MATCH_RATEEST config NETFILTER_XT_MATCH_REALM tristate '"realm" match support' depends on NETFILTER_ADVANCED - select NET_CLS_ROUTE help This option adds a `realm' match, which allows you to use the realm key from the routing subsystem inside iptables.
