Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> > diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h
> > index f7e73c3..dd3f201 100644
> > --- a/include/linux/if_bridge.h
> > +++ b/include/linux/if_bridge.h
> > @@ -103,7 +103,7 @@ struct __fdb_entry {
> >
> > extern void brioctl_set(int (*ioctl_hook)(struct net *, unsigned int, void __user *));
> >
> > -typedef int (*br_should_route_hook_t)(struct sk_buff *skb);
> > +typedef int br_should_route_hook_t(struct sk_buff *skb);
> > extern br_should_route_hook_t __rcu *br_should_route_hook;
>
> Hi Florian
>
> It seems I was on crack at that time, but I remember having problem with
> sparse on :
>
> net/bridge/netfilter/ebtable_broute.c:90:2: error: cannot dereference this type
>
> Lets ignore sparse for the time being...
>
> Please dont change the invocation of (*rhook) to make clear its an
> indirect call. Both syntaxes are valid in C.
okay.
> You also can remove one un needed cast now.
You're right about the cast, but removing it causes the sparse splat
you quoted above...
I'll resend a v2 containing the change below only.
Thanks for looking at this,
Florian
> --- a/include/linux/if_bridge.h
> +++ b/include/linux/if_bridge.h
> extern void brioctl_set(int (*ioctl_hook)(struct net *, unsigned int, void __user *));
>
> -typedef int (*br_should_route_hook_t)(struct sk_buff *skb);
> +typedef int br_should_route_hook_t(struct sk_buff *skb);
> extern br_should_route_hook_t __rcu *br_should_route_hook;
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
