On Mon, Dec 27, 2010 at 09:41:29AM +0100, Jan Engelhardt wrote: > On Monday 2010-12-27 00:58, Florian Westphal wrote: > >NFLOG already does the same thing for NETFILTER_NETLINK_LOG. > >diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig > >index 1534f2b..c617ec9 100644 > >--- a/net/netfilter/Kconfig > >+++ b/net/netfilter/Kconfig > >@@ -477,6 +477,7 @@ config NETFILTER_XT_TARGET_NFLOG > > config NETFILTER_XT_TARGET_NFQUEUE > > tristate '"NFQUEUE" target Support' > > depends on NETFILTER_ADVANCED > >+ select NETFILTER_NETLINK_QUEUE > > help > > This target replaced the old obsolete QUEUE target. > There once was sort of a small debate on whether we should not reduce > the usage of "select" (and instead use: depends on > NETFILTER_NETLINK_QUEUE, in this case). What do people think about it? For users, NETFILTER_XT_TARGET_NFQUEUE is a real thing they want and NETFILTER_NETLINK_QUEUE just an implementation detail. So I suggest select here, like the patch does. Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
