On 18/12/10 21:17, Jan Engelhardt wrote: > Use C++ headers for C++ and throw out #includes that are not needed > for the header file. > > Signed-off-by: Jan Engelhardt <jengelh@xxxxxxxxxx> > --- > include/libnetfilter_log/libipulog.h | 9 ++++++--- > src/libipulog_compat.c | 1 + > 2 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/include/libnetfilter_log/libipulog.h b/include/libnetfilter_log/libipulog.h > index 0278862..bb6736a 100644 > --- a/include/libnetfilter_log/libipulog.h > +++ b/include/libnetfilter_log/libipulog.h > @@ -1,9 +1,12 @@ > #ifndef _LIBIPULOG_H > #define _LIBIPULOG_H > > -#include <errno.h> > -#include <unistd.h> > -#include <fcntl.h> > +#ifdef __cplusplus > +# include <cstdint> > +#else > +# include <stdint.h> > +#endif > +#include <sys/types.h> I agree that these headers shouldn't be there but I'm worry about breaking the compilation of existing applications that, for whatever reason, rely on these includes. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
