On Friday 2010-12-17 17:21, Florian Westphal wrote: > >You are right, > If (foo & bar && baz) > >is used in other places as well. In that case, it is obvious. The odd thing is the precedence of == in C before & and |. In that regard you would not need any parentheses in the quoted part besides those required by the if keyword: >>+ if ((info->invflags & EBT_IP6_PROTO || >>+ info->protocol != IPPROTO_ICMPV6)) >>+ return -EINVAL; > >if ((info->invflags & EBT_IP6_PROTO) || info->protocol != >IPPROTO_ICMPV6) [I guess that tells me I am already autoparenthizing subconsciously when I would not need to.] -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html