On Thursday 2010-12-16 10:57, Jesper Dangaard Brouer wrote: >Cc.ed Thomas Graf (tgraf@xxxxxxxxxx), Thomas presented some interesting >ideas on netlink error-codes and strings during NetConf 2010, see: > >http://vger.kernel.org/netconf2010.html >http://vger.kernel.org/netconf2010_slides/tgraf_netconf10.odp The idea is appending an error string is ok for Netlink as a protocol (specification-wise), but the size constraints of the skbuffs in the Linux may make its practical implementation a little harder. "Half of the packet" is already used for the original request message, and cramming an extra error string may bust the space. It also does not look very netlinky to not use nlattrs ;-) On Wed, 15 Dec 2010, Jozsef Kadlecsik came about with: > >>I have got a three-level error coding in my mind: general, standard >>error codes (ENOMEM, EPERM, etc.), general netfilter specific ones >>(like NFXTE_HOOKMASK_NOT_ADHERED) and table/match/target specific >>ones. >> >>But I do realize that it's much easier (and therefore quite tempting) >>to construct the full error message in kernel space and just send it >>back. However, that'd make quite hard to support internationalization. It's not like those strings change all that much. >To support internationalization, we could just add an error-number-code >in front of the constructed error message? Buying us what? If you change the string, but the gettext lookup is based upon a number, you will get an outdated translation, which is not nice either. IMHO: Better an English message than an inaccurate message. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
