On Wed, 2010-12-15 at 00:43 +0100, Julian Anastasov wrote: > Hello, > > On Mon, 13 Dec 2010, Hans Schillstrom wrote: [snip] > v2 PATCH 13/22 - ip_vs_est > - estimation_timer: what protection is needed for for_each_net? > It is rtnl for user context and RCU for softirq? > May be est_timer must be per NS? Now may be rcu_read_lock is > needed before for_each_net_rcu ? for_each_net can be called > only under rtnl_lock? > [snip] In case of a common timer for all ns: rcu_read_lock(); for_each_net_rcu(net) { ... } rcu_read_unlock(); I guess it's better with a timer per netns ? (then for_each_net() is not needed, and the locking can remain the same as before the netns change.) Regards Hans Schillstrom <hans.schillstrom@xxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html