On Thursday 2010-12-09 11:10, Changli Gao wrote:
>Since instance_table is a static array, and has been zeroed already, we
>don't need to take CPU cycles to initialize it.
>
>Signed-off-by: Changli Gao <xiaosuo@xxxxxxxxx>
>---
> net/netfilter/nfnetlink_queue.c | 3 ---
> 1 file changed, 3 deletions(-)
>diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c
>index 68e67d1..9c80d6f 100644
>--- a/net/netfilter/nfnetlink_queue.c
>+++ b/net/netfilter/nfnetlink_queue.c
>@@ -893,9 +893,6 @@ static int __init nfnetlink_queue_init(void)
> {
> int i, status = -ENOMEM;
>
>- for (i = 0; i < INSTANCE_BUCKETS; i++)
>- INIT_HLIST_HEAD(&instance_table[i]);
>-
> netlink_register_notifier(&nfqnl_rtnl_notifier);
> status = nfnetlink_subsys_register(&nfqnl_subsys);
> if (status < 0) {
This is here for correctness and documentation. If the hlist
implementation changed, one would have a hard time figuring out the
callsites which then need to add the initialization back.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
