On Sun, Nov 21, 2010 at 12:50 AM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote: > Le samedi 20 novembre 2010 à 09:03 -0700, Tim Gardner a écrit : > >> NAK, set_bit() takes a bit number, not a mask. That is, assuming you can >> get away with a non-atomic operation on this field. I'll defer to >> Patrick on that. >> >> I think you have to use IPS_CONFIRMED instead, e.g., >> >> ct->status |= IPS_CONFIRMED; >> > > Or > > __set_bit(IPS_CONFIRMED_BIT, &ct->status); > > > set_bit() is atomic, while __set_bit() is not > Oh, you are right. Thanks. My a previous patch accepted by Patrick has the same problem. -- Regards, Changli Gao(xiaosuo@xxxxxxxxx) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
