On Friday 2010-11-19 12:09, Pablo Neira Ayuso wrote: > >I like this patchset. Some minor glitch: > >On 16/11/10 12:43, Jan Engelhardt wrote: >> @@ -49,31 +43,31 @@ MNL_API int mnl_socket_getsockopt(const struct mnl_socket *nl, int type, void *b >> -MNL_API size_t mnl_nlmsg_size(size_t len); >> -MNL_API size_t mnl_nlmsg_total_size(size_t len); >> -MNL_API size_t mnl_nlmsg_get_payload_len(const struct nlmsghdr *nlh); >> +extern size_t mnl_nlmsg_size(size_t len); >> +extern size_t mnl_nlmsg_total_size(size_t len); >> +extern size_t mnl_nlmsg_get_payload_len(const struct nlmsghdr *nlh); > >In patch 1/6 mnl_nlmsg_next looks like: > >-struct nlattr *mnl_attr_next(const struct nlattr *attr, int *len) >+struct nlattr *mnl_attr_next(const struct nlattr *attr) > >but here the old API seems to come back: > >extern struct nlmsghdr *mnl_nlmsg_next(const struct nlmsghdr *nlh, int >*len); I only changed the attr iteration interface so far, but not yet that of nlmsg iteration. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
