On 11/11/10 13:59, Jan Engelhardt wrote: > On Thursday 2010-11-11 13:57, Pablo Neira Ayuso wrote: > >> On 11/11/10 00:08, Jan Engelhardt wrote: >>> diff --git a/include/libmnl/libmnl.h b/include/libmnl/libmnl.h >>> index 7094af2..37c502a 100644 >>> --- a/include/libmnl/libmnl.h >>> +++ b/include/libmnl/libmnl.h >>> @@ -1,13 +1,16 @@ >>> #ifndef _LIBMNL_H_ >>> #define _LIBMNL_H_ >>> >>> -#include <stdio.h> >>> -#include <stdint.h> >>> +#ifdef __cplusplus >>> +# include <cstdio> >>> +# include <cstdint> >>> +#else >>> +# include <stdbool.h> /* not in C++ */ >>> +# include <stdio.h> >>> +# include <stdint.h> >>> +#endif >>> #include <sys/socket.h> /* for sa_family_t */ >>> #include <linux/netlink.h> >>> -#ifndef __cplusplus >>> -# include <stdbool.h> >>> -#endif >> >> A c++ example compiles fine without this here, so do we really need >> these extra ifdef's? > > Well there is a purpose for having <cXXX> over <XXX.h> in C++. IIRC it > was proper namespacing of Standard Library functions. I'm looking at other library code but I don't find any doing this. If you can point to any, I'd appreciate it. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
