Am 28.10.2010 22:00, schrieb David Miller: > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Date: Thu, 28 Oct 2010 20:51:43 +0200 > >>> + u8 tproto; >> >> tproto is unsigned... >> >>> + const struct xt_socket_mtinfo1 *info = (struct xt_socket_mtinfo1 *) par->matchinfo; >>> + >>> + tproto = ipv6_find_hdr(skb, &thoff, -1, NULL); >> >> but ipv6_find_hdr() returns int, and negative values for errors... > > Thanks Geert, I'll fix it like so: > > -------------------- > netfilter: xt_socket: Make tproto signed in socket_mt6_v1(). > > Otherwise error indications from ipv6_find_hdr() won't be noticed. > > This required making the protocol argument to extract_icmp6_fields() > signed too. > > Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx> Thanks for taking care of this Dave. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
