Hi,
On Thu, 2010-10-21 at 11:14 +0200, Jan Engelhardt wrote:
> On Thursday 2010-10-21 10:50, KOVACS Krisztian wrote:
>
> >Hi,
> >
> >On Thu, 2010-10-21 at 10:47 +0200, Jan Engelhardt wrote:
> >> On Wednesday 2010-10-20 13:21, KOVACS Krisztian wrote:
> >> >
> >> > /* TPROXY target is capable of marking the packet to perform
> >> > * redirection. We can get rid of that whenever we get support for
> >> > * mutliple targets in the same rule. */
> >> >-struct xt_tproxy_target_info {
> >> >+struct xt_tproxy_target_info_v0 {
> >> > u_int32_t mark_mask;
> >> > u_int32_t mark_value;
> >> > __be32 laddr;
> >> > __be16 lport;
> >> > };
> >>
> >> You cannot change the struct name either, or it may break userspace
> >> compilations.
> >
> >True, though iptables has its own copy of the header anyway.
>
> There is - or so I always hear - other userspace programs.
>
> As for iptables, we only do the copy so that it compiles independent of
> the kernel version. You have to assume that the headers can be updated
> at any time.
Sure, I wasn't implying we shouldn't fix this in the patch, I just doubt
there's anything else other than iptables using this and iptables itself
isn't affected.
Anyway, I've fixed it. Thanks, Jan.
--KK
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
