Am 02.10.2010 17:07, schrieb Eric Dumazet: > ipt_LOG & ip6t_LOG use lot of calls to printk() and use a lock in a hope > several cpus wont mix their output in syslog. > > printk() being very expensive [1], its better to call it once, on a > prebuilt and complete line. Also, with mixed IPv4 and IPv6 trafic, > separate IPv4/IPv6 locks dont avoid garbage. > > I used an allocation of a 1024 bytes structure, sort of seq_printf() but > with a fixed size limit. > Use a static buffer if dynamic allocation failed. > > Emit a once time alert if buffer size happens to be too short. > > [1]: printk() has various features like printk_delay()... Nice work, applied, thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
