Re: [PATCH] netfilter: don't disable BH again in BH disabled context

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le mercredi 22 septembre 2010 Ã 18:20 +0800, Changli Gao a Ãcrit :
> On Tue, Aug 17, 2010 at 2:55 PM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> >
> > Its a thing that might change in a future version. Not a hard fact.
> >
> > You can probably change iptables to allow softirqs while processing
> > OUTPUT chains.
> >
> > We had some attempts in the past to switch to RCU.
> >
> > It failed at that time because of some RCU implementation details, but
> > with recent RCU changes, we might try again, and have a clean
> > implementation, allowing softirqs.
> >
> > So your patch would need to be reverted.
> >
> 
> So the smp_processor_id() in xt_cpu.c should be replaced with
> raw_smp_processor_id()?
> 

Using smp_processor_id() is better. This provides automatic checking.

If we change output processing to allow softirqs, that doesnt mean we
allow preemption or cpu migration :)



--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux