On Friday 2010-08-20 18:17, Eric Dumazet wrote: >> + if (unlikely(!nf_conntrack_hash_rnd)) { >> + unsigned int rand; >> + >> + /* Why not initialize nf_conntrack_rnd in a "init()" function ? >> + * Because there isn't enough entropy when system initializing, >> + * and we initialize it as late as possible. */ > >This patch is fine but a fine multi line comment is : > /* Some > * fine > * comment > */ Actually, /* * Some */ But that's in CodingStyle already. Always a good read, even if reread. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html